Quoting Douglas Anderson (2018-08-10 14:51:48)
> From: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
>
> This adds nodes for USB and related PHYs.
>
> Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
> [dianders: reworked quite a bit]
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
One question below, otherwise
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
> Changes in v2:
> - Use "0x784000" for qfprom rather than "0x780000" as per docs.
?
> - Add calibration for 2nd USB port too
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 196 +++++++++++++++++++++++++++
> 1 file changed, 196 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index ae57c065780c..f13d8c2fb4a5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -8,6 +8,7 @@
> #include <dt-bindings/clock/qcom,gcc-sdm845.h>
> #include <dt-bindings/clock/qcom,rpmh.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/phy/phy-qcom-qusb2.h>
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>
> / {
> @@ -249,6 +250,23 @@
> #power-domain-cells = <1>;
> };
>
> + qfprom@784000 {
This doesn't match reg property.
> + compatible = "qcom,qfprom";
> + reg = <0x780000 0x8ff>;
Because this should be 0x784000?
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + qusb2p_hstx_trim: hstx-trim-primary@1eb {
> + reg = <0x1eb 0x1>;
> + bits = <1 4>;
> + };
> +
> + qusb2s_hstx_trim: hstx-trim-secondary@1eb {
> + reg = <0x1eb 0x2>;
> + bits = <6 4>;
> + };
> + };
> +
> qupv3_id_0: geniqup@8c0000 {
> compatible = "qcom,geni-se-qup";
> reg = <0x8c0000 0x6000>;
