Quoting Taniya Das (2018-06-28 04:47:31) > @@ -3437,7 +3457,12 @@ static int gcc_sdm845_probe(struct platform_device *pdev) > regmap_update_bits(regmap, 0x48190, BIT(0), 0x1); > regmap_update_bits(regmap, 0x52004, BIT(22), 0x1); > > - return qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap); > + ret = qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap); > + if (ret) > + return ret; > + > + return qcom_cc_register_rcg_dfs(pdev, gcc_dfs_clocks, > + ARRAY_SIZE(gcc_dfs_clocks)); This looks backwards. We shouldn't expose the clks to drivers and then make their functionality work by registering dfs clks. The order should be swapped. -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
