On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
> In order to support eh Qualcomm MDM9615 SoC, add support for the
> PM8018 RPM regulator in the qcom_rpm-regulator driver.
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
[..]
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
[..]
> +/**
> + * enum rpm_vreg_voltage_corner - possible voltage corner values
> + *
> + * These should be used in regulator_set_voltage and rpm_vreg_set_voltage calls
> + * for corner type regulators as if they had units of uV.
> + */
> +enum rpm_vreg_voltage_corner {
> + RPM_VREG_CORNER_NONE = 1,
> + RPM_VREG_CORNER_LOW,
> + RPM_VREG_CORNER_NOMINAL,
> + RPM_VREG_CORNER_HIGH,
> +};
> +
> +static struct regulator_linear_range corner_ranges[] = {
> + REGULATOR_LINEAR_RANGE(RPM_VREG_CORNER_NONE, 0,
> + RPM_VREG_CORNER_HIGH, 1),
> +};
> +
> static int rpm_reg_write(struct qcom_rpm_reg *vreg,
[..]
> +
> +static const struct qcom_rpm_reg pm8018_corner = {
> + .desc.linear_ranges = corner_ranges,
> + .desc.n_linear_ranges = ARRAY_SIZE(corner_ranges),
> + .desc.n_voltages = 4,
> + .desc.ops = &uV_ops,
> + .parts = &rpm8018_corner_parts,
> +};
> +
[..]
> +static const struct rpm_regulator_data rpm_pm8018_regulators[] = {
[..]
> + { "dig_corner", QCOM_RPM_VOLTAGE_CORNER, &pm8018_corner,
> + "vdd_dig_corner" },
> +
> + { }
> +};
We have discussed the corners for a long time and I think we've
concluded that they should be exposed as something like an OPP. What we
have agreed on is that they should not be exposed as a regulator with
voltages 1-4uV.
So please drop the corner for now.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
