On Tue, Oct 13, 2015 at 01:57:43PM -0700, Bjorn Andersson wrote: > The BIT() was incorrectly inherited from family A and should not be used > on family B where the state is denoted by an enum. > > Reported-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > --- > drivers/soc/qcom/smd-rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c > index b5feb58dbd9f..2969321e1b09 100644 > --- a/drivers/soc/qcom/smd-rpm.c > +++ b/drivers/soc/qcom/smd-rpm.c > @@ -126,7 +126,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm, > pkt->hdr.length = cpu_to_le32(sizeof(struct qcom_rpm_request) + count); > > pkt->req.msg_id = cpu_to_le32(msg_id++); > - pkt->req.flags = cpu_to_le32(BIT(state)); > + pkt->req.flags = cpu_to_le32(state); Right, nice catch. I'll queue it up. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
