Re: [PATCH][RFC] MIPS: BCM47XX: Move NVRAM driver to the drivers/firmware/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11 December 2014 at 00:16, Paul Walmsley <paul@xxxxxxxxx> wrote:
> On Wed, 10 Dec 2014, Rafał Miłecki wrote:
>
>> After Broadcom switched from MIPS to ARM for their home routers we need
>> to have NVRAM driver in some common place (not arch/mips/).
>> We were thinking about putting it in bus directory, however there are
>> two possible buses for MIPS: drivers/ssb/ and drivers/bcma/. So this
>> won't fit there neither.
>> This is why I would like to move this driver to the drivers/firmware/
>>
>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
>> ---
>> Hey, this is another try for the NVRAM driver. At first I tried moving it to the
>> drivers/misc/, but then decided drivers/soc/ will be better. Then after
>> discussion with Paul we decided to try drivers/firmware/ and so I do.
>>
>> Meanwhile I've sent few patches cleaning nvram.c: following kernel coding style
>> and using helpers like readl.
>>
>> I would like to get few Reviewed-by for this patch. If I get that, then I'll
>> re-send this patch to Ralf without the RFC.
>>
>> If you want to review nvram.c code, please make sure to check version in
>> ralf/upstream-sfr.git repository as it contains many cleanups:
>> git://git.linux-mips.org/pub/scm/ralf/upstream-sfr.git
>> http://git.linux-mips.org/cgit/ralf/upstream-sfr.git/log/
>>
>> Mentioned patches (more cleanups):
>> http://patchwork.linux-mips.org/project/linux-mips/list/?submitter=478
>>
>> Finally: why drivers/firmware/? Please see Paul's e-mail:
>> <alpine.DEB.2.02.1411271926560.1406@xxxxxxxxxxxxxxxxxx>
>> http://www.linux-mips.org/archives/linux-mips/2014-11/msg00678.html
>>
>> Unfortunately there is no mailing list for drivers/firmware/, so I've
>> picked ppl with 5+ commits to this directory. Hope this is OK.
>
> Reviewed-by: Paul Walmsley <paul@xxxxxxxxx>
>
> Just to restate, if it's unclear for any other reviewers (as it initially
> was for me): this isn't an NVRAM driver as most folks understand the term.
> This "NVRAM" code parses SoC configuration data that is passed to the
> kernel in flash from the bootloader firmware, "CFE".

Thanks Paul.

Could anyone else review this, please?

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux