On 4/17/20 5:12 PM, Vineet Gupta via Libc-alpha wrote:
> On 4/17/20 4:10 PM, Joseph Myers wrote:
>> On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote:
>>
>>> + GLIBC_PRIVATE {
>>> + # A copy of sigaction lives in libpthread, and needs these.
>>> + __default_rt_sa_restorer;
>>> + }
>>
>> Not a requirement for this port, given that this is GLIBC_PRIVATE so can
>> always be changed later, but does sigaction actually need to live in
>> libpthread?
>
> From my old branches, I added this back in 2018 when working on some cancellation
> failures.
>
>> Or given the work that's been done on moving functions from
>> libpthread to libc (and the corresponding dynamic linker work that mean
>> it's now possible to move versioned symbols like that), could the copy of
>> sigaction in libpthread be removed?
>
> I don't think there's any ARC specific code which requires a restorer copy in
> libpthread. I can remove this and give the build a spin to see if anything breaks.
As of today, libpthread_pic.a includes sigaction.os hence the need for export as
well: removing it from Version file causes build errors.
But when sigaction.os dependency is removed, this won't be needed.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
