Re: [PATCH v2] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 24 Feb 2020, Vineet Gupta wrote:

> diff --git a/sysdeps/unix/sysv/linux/fxstat64.c b/sysdeps/unix/sysv/linux/fxstat64.c
> index 9133a0a29b8e..93394c450f1c 100644
> --- a/sysdeps/unix/sysv/linux/fxstat64.c
> +++ b/sysdeps/unix/sysv/linux/fxstat64.c
> @@ -33,15 +33,15 @@ int
>  ___fxstat64 (int vers, int fd, struct stat64 *buf)
>  {
>    int result;
> -#ifdef __NR_fstat64
> -  result = INLINE_SYSCALL (fstat64, 2, fd, buf);
> -#else
> +# if STAT64_IS_NOT_KERNEL_STAT64 || !defined(__NR_fstat64)

I don't think the extra space after "#" is correct here.  We use such 
spaces to indicate the level of nesting inside outer #if conditionals, but 
there is no outer #if conditional around this one in this file, so "#if" 
without the space is correct.

There should be a space before '(' in the "defined" call.

Likewise in other files changed by this patch.

Joseph S. Myers

linux-snps-arc mailing list

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux