>From: Vineet Gupta [mailto:Vineet.Gupta1 at synopsys.com] >Sent: Monday, August 21, 2017 20:04 PM .... >> + >> +/* Handle an out of bounds mtm hs counter value */ static void __init >> +handle_mtm_hs_ctr_out_of_bounds_error(uint8_t val) { >> + pr_err("** The value must be in range [%d,%d] (inclusive)\n", >> + MT_HS_CNT_MIN, MT_HS_CNT_MAX); >> + >> + mtm_hs_ctr = val; >This error handling doesn't make sense to me - if the value is not in range, why bother setting it at all. I'll fix it up locally. Just look what we provide handle_mtm_hs_ctr_out_of_bounds_error() as parameter and it will be sensible to you :) Noam
