Re: [PATCH] x86/sgx: Return VM_FAULT_SIGBUS for EPC exhaustion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Huang, Kai <kai.huang@xxxxxxxxx> wrote:

> On Thu, 2023-10-26 at 11:34 -0500, Haitao Huang wrote:
> > On Thu, 26 Oct 2023 11:01:57 -0500, Reinette Chatre  
> > <reinette.chatre@xxxxxxxxx> wrote:
> > 
> > > 
> > > 
> > > On 10/25/2023 4:58 PM, Huang, Kai wrote:
> > > > On Wed, 2023-10-25 at 07:31 -0700, Hansen, Dave wrote:
> > > > > On 10/19/23 19:53, Haitao Huang wrote:
> > > > > > In the EAUG on page fault path, VM_FAULT_OOM is returned when the
> > > > > > Enclave Page Cache (EPC) runs out. This may trigger unneeded OOM kill
> > > > > > that will not free any EPCs. Return VM_FAULT_SIGBUS instead.
> > > 
> > > This commit message does not seem accurate to me. From what I can tell
> > > VM_FAULT_SIGBUS is indeed returned when EPC runs out. What is addressed
> > > with this patch is the error returned when kernel (not EPC) memory runs
> > > out.
> > > 
> > 
> > 
> > Sorry I got it mixed up between sgx_alloc_epc_page and sgx_encl_page_alloc  
> > returns.
> > You are right. Please drop this patch.
> > 
> 
> It's already in tip/x86/urgent.  Please send a patch to revert?

No, let's just zap it.

Thanks,

	Ingo



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux