On 10/19/23 19:53, Haitao Huang wrote: > In the EAUG on page fault path, VM_FAULT_OOM is returned when the > Enclave Page Cache (EPC) runs out. This may trigger unneeded OOM kill > that will not free any EPCs. Return VM_FAULT_SIGBUS instead. So, when picking an error code and we look the documentation for the bits, we see: > * @VM_FAULT_OOM: Out Of Memory > * @VM_FAULT_SIGBUS: Bad access So if anything we'll need a bit more changelog where you explain how running out of enclave memory is more "Bad access" than "Out Of Memory". Because on the surface this patch looks wrong. But that's just a naming thing. What *behavior* is bad here? With the old code, what happens? With the new code, what happens? Why is the old better than the new?
