Re: [PATCH v3 0/3] x86/sgx: fine grained SGX MCA behavior

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2022-06-06 at 22:40 +1200, Kai Huang wrote:
> On Fri, 2022-06-03 at 13:15 +1200, Du, Fan wrote:
> > > 
> > > This applies on top of Cathy's series, right? Why not send one
> > > series with all 12 patches included?
> > > 
> > > It makes reviewing easier, and we are well beyond 5.19 timeline
> > > for these features.
> > 
> > Patches from Zhiquan try to improve SGX MCA handling, actually this is a BUG
> > being
> > discussed with customer with SGX deployment already - SGX VM instance got
> > killed
> > in case of SGX application inside VM consumed poison EPC pages. Expected
> > behavior:
> > SGX application get killed only in such scenario.
> > 
> > Seamless patchset from Catchy is another standalone feature, the design seems
> > still under discussion. Combining those two distinct purpose-built patchset
> > together
> > looks wired.
> 
> Right.  Those are two different features and I don't see why they should be sent
> out together.
> 
> Btw, please also note Cathy's SGX rebootless recovery may never get accepted:
> 
> https://lore.kernel.org/linux-sgx/Yo0xSNt0JKGgOG59@xxxxxxx/T/#m4d1a56fc3ed547d200443dab50bed6484e6d2e1d
> https://lore.kernel.org/all/20220524185324.28395-1-bp@xxxxxxxxx/

Considering Zhiquan's series: all the patches have different message ID,
which puts them into different threads and makes it hard to apply.

E.g.

https://lore.kernel.org/linux-sgx/20220525100625.760633-1-zhiquan1.li@xxxxxxxxx/T/#u

https://lore.kernel.org/linux-sgx/20220525100730.760815-1-zhiquan1.li@xxxxxxxxx/T/#u

Zhiquan: can you send your patch series as a single series? Easiest
way to do it is to use git send-email. Right now the series broken.

BR, Jarkko




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux