On Wed, Feb 09, 2022 at 09:19:54PM +0100, Alejandro Colomar (man-pages) wrote: > Hi Jarkko, > > On 1/28/22 02:19, Jarkko Sakkinen wrote: > > On Fri, Dec 17, 2021 at 02:50:56AM +0100, Alejandro Colomar (man-pages) wrote: > >> Hi Jarkko, > >> > >> Please see some comments below. > >> > >> Thanks, > >> Alex > > > > Thank you. I've addressed all the comments below. However, I feel that > > /dev/sgx_provision is not properly documented at all. I also think that > > Reinette's argument for v10 was fair that "remove VEPC" ioctl that QEMU > > uses should not be left out from the initial patch set. > > > > I'm implementing user space that doest attestation, so I rather write a > > proper description of the attestation, once it is working, rather than add > > to the number of review rounds. > > Fair enough. Please send an v12 with those comments addressed, and I'll > merge it! (if you miss anything, we'll fix it later, don't worry) It took me two weeks to do the remote attestation implementation for Enarx project [*] but I needed to do it before continuing with the man page. I'll continue with this some time next week. It's not exactly directly attached to kernel API but I think it is good to bring some context on that. [*] https://github.com/enarx/enarx/pull/1329 BR, Jarkko
