On Mon, 2021-12-06 at 13:45 -0800, Reinette Chatre wrote: > Hi Jarkko, > > On 12/4/2021 3:14 PM, Jarkko Sakkinen wrote: > > > diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c > > > index 342b97dd4c33..37203da382f8 100644 > > > --- a/arch/x86/kernel/cpu/sgx/encl.c > > > +++ b/arch/x86/kernel/cpu/sgx/encl.c > > > @@ -403,6 +403,10 @@ int sgx_encl_may_map(struct sgx_encl *encl, unsigned long start, > > > > > > XA_STATE(xas, &encl->page_array, PFN_DOWN(start)); > > > > > > > Please write a comment here. > > Would the comment below suffice? > > /* Disallow mapping outside enclave's address range. */ Yeah, looks good to me. /Jarkko
