On Wed, Sep 18, 2019 at 07:12:25AM +0300, Jarkko Sakkinen wrote: > On Tue, Sep 17, 2019 at 04:07:40PM -0700, Sean Christopherson wrote: > > On Mon, Sep 16, 2019 at 01:17:58PM +0300, Jarkko Sakkinen wrote: > > > Open code sgx_reclaimer_get() and sgx_reclaimer_put(). They are legacy > > > from the callback interface. Wrapping a function call inside a function > > > does not make sense. > > > > I actually like the functions, IMO they make the loops more readable. > > They should be static, and probably static inline, but I doubt either > > annotation affects the compiler output. > > The way I see it they only add to need to cross reference when you read > the code. Wrapping a single function call makes only sense when you > actually have a semantical need for it. It also incosistent to have the wrappers as in other call sites kref_put() is used "raw". If we have a wrapper, it should be used consistently in every possible call site. /Jarkko
