On Fri, Aug 23, 2019 at 07:04:04PM +0300, Jarkko Sakkinen wrote: > On Fri, Aug 23, 2019 at 06:02:48PM +0300, Jarkko Sakkinen wrote: > > 3. Why don't just store SECINFO flags on EADD? Doing > > calc_vma_prot_bits() on fly is not expensive. Now > > data in SECINFO flags is scattered to two different > > fields (desc and vm_max_prot_bits). I'd just have a field > > called secinfo_flags. > > Makes sense to have that field as a cache so that we don't have to do > recalc per page in the sgx_encl_may_map() and thus makes sense to keep > TCS tagging in desc. (1) and (2) I will remark in v22 patch review. It is better to do that way. I squashed my remaining fixes that I just posted to the patch set. The final change log for v22 is: * Alignment checks have been removed from mmap() because it does not define the ELRANGE. VMAs only act as windows to the enclave. The semantics compare somewhat how mmap() works with regular files. * We now require user space addresses given to SGX_IOC_ENCLAVE_ADD_PAGE to be page aligned so that we can pass the page directly to EADD and do not have to do an extra copy. This was made effectively possible by removing the worker thread for adding pages. * The selftest build files have been refined throughout of various glitches and work properly in a cross compilation environment such as BuildRoot. In addition, libcalls fail the build with an assertion in the linker script, if they end up to the enclave binary. * CONFIG_INTEL_SGX_DRIVER has been removed because you cannot use SGX core for anything without having the driver. This could change when KVM support is added. * We require zero permissions in SECINFO for TCS pages because the CPU overwrites SECINFO flags with zero permissions and measures the page only after that. Allowing to pass TCS with non-zero permissions would cause mismatching measurement between the one provided in SIGSTRUCT and the one computed by the CPU. As I noted I can ATM run only selftest as the stress test that I'm using is not yet working with the latets API changes. Can you give it a shot? /Jarkko
