On Thu, 2019-08-22 at 19:13 +0300, Jarkko Sakkinen wrote: > On Thu, 2019-08-22 at 18:02 +0300, Jarkko Sakkinen wrote: > > On Thu, 2019-08-22 at 17:59 +0300, Jarkko Sakkinen wrote: > > > On Wed, 2019-08-21 at 20:42 -0700, Sean Christopherson wrote: > > > > On Mon, Aug 19, 2019 at 04:28:30PM +0300, Jarkko Sakkinen wrote: > > > > > Recurse into a list of subdirectories defined by SUBDIRS when running > > > > > x86 selftests. Override run_tests, install, emit_tests and clean > > > > > targets to implement this behaviour. > > > > > > > > The code looks good (which doesn't say much, my Makefile knowledge is > > > > garbage), but the result is a bit odd. x86/sgx doesn't implement > > > > emit_tests (or at least test_sgx doesn't show up), while the rest of the > > > > x86 tests don't support install. > > > > > > > > AFAICT the Makefile is itself weird; it's definitely different than other > > > > selftests Makfiles. I don't see any reason to delay this patch, but it > > > > feels like something here needs to be cleaned up. > > > > > > Lets fix emit_tests before sending v22. > > > > Selftest patches have been squahed. Further improvements are welcome. > > Thanks for the review! > > At least my use case is satisfied with these fixes: > > $ ls output/target/usr/lib/kselftests/x86 > test_sgx > > I can build initramfs now with the selftest bundled. Oddly enough none of the > other x86 selftests get included. # ls /usr/lib/kselftests/x86 test_sgx # /usr/lib/kselftests/x86/test_sgx Binary size 24576 (0x6000), SIGSTRUCT size 1808 Loading the enclave. Input: 0x1122334455667788 Output: 0x1122334455667788 This is a big improvement for me :-) Do not have to upload selftest anymore with minicom or scp. /Jarkko
