Re: [PATCH v3 7/7] selftests/x86: Recurse into subdirectories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-08-21 at 20:42 -0700, Sean Christopherson wrote:
> On Mon, Aug 19, 2019 at 04:28:30PM +0300, Jarkko Sakkinen wrote:
> > Recurse into a list of subdirectories defined by SUBDIRS when running
> > x86 selftests. Override run_tests, install, emit_tests and clean
> > targets to implement this behaviour.
> 
> The code looks good (which doesn't say much, my Makefile knowledge is
> garbage), but the result is a bit odd.  x86/sgx doesn't implement
> emit_tests (or at least test_sgx doesn't show up), while the rest of the
> x86 tests don't support install.
> 
> AFAICT the Makefile is itself weird; it's definitely different than other
> selftests Makfiles.  I don't see any reason to delay this patch, but it
> feels like something here needs to be cleaned up.

Lets fix emit_tests before sending v22.

/Jarkko




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux