On Mon, Aug 12, 2019 at 06:22:27PM -0700, Sean Christopherson wrote: > Nope, KVM does not have any dependencies on the native driver. But if > sgx_drv_init() returns 0 when CONFIG_INTEL_SGX_DRIVER=n, then sgx_init() > won't handle KVM failure correctly since it will think the native driver > initialized cleanly. E.g. with both KVM and driver in play, I was > thinking of something like this in sgx_init(): > > /* Success if the native *or* virtual driver initialized cleanly. */ > ret = sgx_drv_init(); > ret = sgx_virt_epc_init() ? ret : 0; > if (ret) > goto err; > > return 0; > > If sgx_drv_init() returns 0 when CONFIG_INTEL_SGX_DRIVER=n, then failure > in sgx_virt_epc_init() is ignored and we end up with the SGX subsystem > wasting resources again. I get what you are saying but what exist now does not align with this and on the other hand nothing prevents the reconsider the flow once we get to this point. /Jarkko
