Re: [PATCH] x86/sgx: Return 0 when !CONFIG_INTEL_SGX_DRIVER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 15, 2019 at 06:59:03AM -0700, Sean Christopherson wrote:
> On Sun, Jul 14, 2019 at 05:32:12PM +0300, Jarkko Sakkinen wrote:
> > When the config option is not enabled the initialization is always
> > succesful.
> 
> Why would the be initialization be considered successful?  It's dead code
> and memory consumption if the driver can't load.  When KVM support gets
> added, the initialization can be considered successful if the driver *or*
> virtual EPC are enabled and load cleanly.

When a config option disabled means it that the functionality does not
exist at all, which means that there is nothing to fail. That is why it
would be actually better to flag the whole call than the way it is done
in this patch.

/Jarkko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux