On 7/14/2019 7:47 AM, Jarkko Sakkinen wrote:
On Sat, Jul 13, 2019 at 10:20:58AM -0700, Xing, Cedric wrote:
Like I said, there are plenty of test### functions in the selftests. And
your original version didn't have even a name - everything was inside main()
without any comments. How was your original version "reviewable"?
I don't care. We can do better than that.
Not that they did a poor job. You probably don't understand the
intention here. Naming tests with numbers helps users correlate test
outputs with test functions.
If you have a specific thing that needs a comment in my selftest, please
remark and I can add it.
You should have enclosed your test code in a function to be separated
from the initialization code (e.g. finding vDSO in memory, locating API,
etc.). My patch actually did that for you.
As for your last question, I neither care about metaphysics. Please,
stick to the content.
I tried to point out you are implementing a double standard here. Please
do not misinterpret it.
/Jarkko
