On 7/13/2019 8:21 AM, Jarkko Sakkinen wrote:
On Fri, 2019-07-12 at 23:51 -0700, Cedric Xing wrote:This patch augments SGX selftest with two new tests. The first test exercises the newly added callback interface, by marking the whole enclave range as PROT_READ, then calling mprotect() upon #PFs to add necessary PTE permissions per PFEC (#PF Error Code) until the enclave finishes. This test also serves as an example to demonstrate the callback interface. The second test single-steps through __vdso_sgx_enter_enclave() to make sure the call stack can be unwound at every instruction within that vDSO API. Its purpose is to validate the hand-crafted CFI directives in the assembly. Besides the new tests, this patch also fixes minor problems in the Makefile, such as: * appended "--build-id=none" to ld command line to suppress the ".note.gnu.build-id section discarded" linker warning. * removed "--remove-section=.got.plt" from objcopy command line as that section would never exist in statically linked (enclave) images. Signed-off-by: Cedric Xing <cedric.xing@xxxxxxxxx>This is also in "unreviewable" state. And you ignored the comment about the function names.
Like I said, there are plenty of test### functions in the selftests. And your original version didn't have even a name - everything was inside main() without any comments. How was your original version "reviewable"?
All I asked was patch that just changes the calling convention to send v21 and include the vDSO change. How hard can that be?
Your selftest Makefile was broken. You had to run the test manually. It broke the build on 32-bit platforms.
Also do not add the main LKML (linux-kernel@xxxxxxxxxxxxxxx) to these patches that are not directly against the mainline. That is only causing unnecessary saturation and noise.
My apology for that. I'll take note.
Thank you. /Jarkko
