On 2018-11-19 22:49, Jarkko Sakkinen wrote:
On Mon, Nov 19, 2018 at 04:22:54PM +0000, Jethro Beekman wrote:On 2018-11-19 20:36, Jarkko Sakkinen wrote:Question: should be dissolve the driver completely and move this code to arch/x86/kernel/cpu/sgx/ (and rename intel_sgx.c as main.c)? Swapping patch removes the possibility to compile this as a module anyway.No. We should keep the capability to build this as a module for other users of SGX. What is the swapping patch and why doesn't allow building as a module?In some earlier version of the patch set the request was to remove the callback interface to the driver so now core does direct calls to the swapping operations.
I see, you're talking about this part (from PATCH v17 20/23):
This has the unfortunate and odd side effect of preventing the SGX driver from being compiled as a loadable module.
But you also write:
However, this should be a temporary situation
And in PATCH v17 19/23:
Allowing the userspace-facing driver to be built as a loaded module is desirable
I wholeheartedly agree with that last statement.Let's keep it as separated as possible for now until KVM lands and we get the module capability back, instead of integrating everything so tightly that that is no longer possible.
-- Jethro Beekman | Fortanix
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
