Hi Paul,
> We discussed both approaches internally and did an initial
> proof-of-concept of a separate driver. The result was over 1,000 lines
> of code copy-pasted from the existing sh-sci driver into the new driver,
> which is generally something maintainers want us to avoid doing.
Darn, 1000 lines of logic is a lot...
> trade off here is whether we want a single more complex driver, or two
> copies of much of the code so that bugfixes/improvements to the common
> sections in the future need to be duplicated.
Exactly.
> The RZ/V2H and RZ/G3E have interfaces of both the existing sh-sci
> register layout ("SCIF" ports in RZ/V2H & RZ/G3E manual) and the RZ/T2H
> style register layout ("RSCI" ports in RZ/V2H manual, "SCI" ports in
> RZ/G3E manual), so keeping things closely aligned as we move forward
> will be beneficial. I expect that this will be easier with a combined
> driver.
I will have a look at the series.
Happy hacking,
Wolfram
Attachment:
signature.asc
Description: PGP signature
