> -----Original Message-----
> From: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Sent: Tuesday, March 11, 2025 11:51 AM
> To: Sherry Sun <sherry.sun@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; Shenwei Wang <shenwei.wang@xxxxxxx>
> Subject: Re: [PATCH V2 3/3] tty: serial: lpuart: rename register variables more
> specifically
>
> On 11. 03. 25, 4:33, Sherry Sun wrote:
> > There are many fuzzy register variables in the lpuart driver, such as
> > temp, tmp, val, reg. Let's give these register variables more specific
> > names.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@xxxxxxx>
> > ---
> > drivers/tty/serial/fsl_lpuart.c | 220 ++++++++++++++++----------------
> > 1 file changed, 110 insertions(+), 110 deletions(-)
> >
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c index f830b5a3ba8e..901c83461bfc
> > 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -441,36 +441,36 @@ static unsigned int
> > lpuart_get_baud_clk_rate(struct lpuart_port *sport)
> >
> > static void lpuart_stop_tx(struct uart_port *port)
> > {
> > - unsigned char temp;
> > + unsigned char cr2;
>
> Overall looks good. In cases like these (there are many), you should have
> switched this to u8 in patch 1/3 too ;).
Hi Jiri,
Looks like lpuart driver needs more thorough clean. :)
Sure, will add u8 changes in V3.
Best Regards
Sherry
