On Mon, Jan 27, 2025 at 06:07:13PM +0800, Yu-Chun Lin wrote: > On Mon, Jan 27, 2025 at 10:12:47AM +0100, Greg KH wrote: > > > So I should remove of_match_ptr and add the CONFIG_OF as a dependency > > > for the configuration. Correct? > > > > I don't know, but putting #ifdef in .c files is not the correct solution > > at all. > > I fixed the build warning this way because I saw it was done the same way > in these three files: > > drivers/tty/serial/samsung_tty.c > drivers/tty/serial/mps2-uart.c > drivers/tty/serial/altera_jtaguart.c Those too should be fixed properly. > Or maybe we can add __maybe_unused to avoid the warning? No, again, no other bus has this issue, please fix the macros properly. thanks, greg k-h
