Hi, On Mon, Jan 13, 2025 at 9:29 AM Amal Raj T <tjarlama@xxxxxxxxx> wrote: > > From: Amal Raj T <amalrajt@xxxxxxxx> > > The current implementation of `poll_put_char` in the serial console driver > performs LF -> CRLF replacement, which can corrupt binary data. Since kdb > is the only user of `poll_put_char`, this patch moves the LF -> CRLF > replacement logic to kdb. > > Link: https://lore.kernel.org/linux-debuggers/Zy093jVKPs9gSVx2@telecaster/ > --- > drivers/tty/serial/serial_core.c | 2 -- > kernel/debug/kdb/kdb_io.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) You seem to have dropped your Signed-off-by? It was there on V2 [1]. ...and speaking of V2, I provided my Reviewed-by there. You should have carried it forward since there are no differences in the code between V2 and V3. I can give it again, but it would be nice not to need to repeat when you send the V4. Once you've added back your own Signed-off-by, you can also add: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> ...also speaking of V2, I did ask if you could maybe add something to the commit message pointing at the previous discussion. If you really have a reason not to do this I won't insist, but it would be nice to include it... [1] https://lore.kernel.org/all/20241211153955.33518-3-tjarlama@xxxxxxxxx/
