On 20/01/2025 13:59, Benjamin Larsson wrote: > On 2025-01-20 08:57, Krzysztof Kozlowski wrote: >> On Sun, Jan 19, 2025 at 02:01:04PM +0100, Benjamin Larsson wrote: >>> The Airoha SoC family have a mostly 16550-compatible UART >>> and High-Speed UART hardware with the exception of custom >>> baud rate settings register. >>> >>> Signed-off-by: Benjamin Larsson <benjamin.larsson@xxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/serial/8250.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml >>> index 692aa05500fd..2fbb972e5460 100644 >>> --- a/Documentation/devicetree/bindings/serial/8250.yaml >>> +++ b/Documentation/devicetree/bindings/serial/8250.yaml >>> @@ -63,6 +63,8 @@ properties: >>> - const: mrvl,pxa-uart >>> - const: nuvoton,wpcm450-uart >>> - const: nuvoton,npcm750-uart >>> + - const: airoha,airoha-uart >>> + - const: airoha,airoha-hsuart >> I assume you placed it matching existing order (kind of alphabetical for >> compatibles with vendors)? >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> Best regards, >> Krzysztof >> > Hi, I placed it after nuvoton that was the most recent addition to the > serial8250_config uart_config[] table that was also added to the But wasn't nuvoton placed in specific, ordered place? > 8250.yaml binding. IIRC I noted that there was no clear order in the > binding list. So the placement could be considered as random. If another > place is better I can move it for the next version of the patch. Entries with vendor look to me fully ordered by name. Best regards, Krzysztof
