On Mon, Jan 20, 2025 at 11:22:12AM +0800, Wenhua Lin wrote: > The sc9632-uart is incompatible > with sc9836-uart, Add sc9632-uart dedicated compatible Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Missing full stop. Your commit msg should explain briefly why sc9632-uart is incompatible with sc9836-uart. > for representing uart of the new project UMS9632 SoC. > > Change in V2: > -Change commit message in PATCH 2/2. > -Modify the compatible string of enum in PATCH 2/2. Changelog goes to changelog place, under ---. > > Signed-off-by: Wenhua Lin <Wenhua.Lin@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > index a2a5056eba04..83582aa6c750 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > @@ -17,13 +17,17 @@ properties: > oneOf: > - items: > - enum: > - - sprd,sc9632-uart > - sprd,sc9860-uart > - sprd,sc9863a-uart > - sprd,ums512-uart > - sprd,ums9620-uart > - const: sprd,sc9836-uart > - const: sprd,sc9836-uart > + - items: > + - enum: > + - sprd,ums9632-uart > + - const: sprd,sc9632-uart Lists are ordered by fallback, so this goes before list ending sprd,sc9836-uart. Do not break orders by putting everything always at the end. > + - const: sprd,sc9632-uart Combine two such const items into enum: - enum - sprd,sc9632-uart - sprd,sc9836-uart Best regards, Krzysztof
