On Tue, Jan 14, 2025 at 3:38 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 14/01/2025 06:45, Wenhua Lin wrote: > > Due to the platform's new project uart ip upgrade, > > the new project's timeout interrupt needs to use bit17 > > while other projects' timeout interrupt needs to use > > bit13, using private data to adapt and be compatible > > Where is private data in this patch? Hi Krzysztof: This private data is a modification of the serial driver. Due to the modification of the driver, the new project ums9632 SoC needs to use SC9632 to be compatible. Thanks > > > with all projects. The sc9632-uart is incompatible > > with sc9836-uart, Add sc9632-uart dedicated compatible > > for representing uart of the new project UMS9632 SoC. > > First part of commit said these are not compatible. Here you claim they > are compatible, so this is just confusing. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > Hi Krzysztof: Sorry, I may have made a mistake, the patch version was submitted incorrectly. We want to submit this version https://lore.kernel.org/all/987b764e-17a6-4280-95e2-858d4c74a8d5@xxxxxxxxxx/, but since this submission PATCH V1 has been merged, we made a new submission, but when doing the dtbs_check and dt_binding_check checks locally, we deliberately changed an error to see if the check is effective, but when submitting, the patch version was submitted incorrectly. Thanks > > > > Signed-off-by: Wenhua Lin <Wenhua.Lin@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/serial/sprd-uart.yaml | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > index a2a5056eba04..35fe9c301cd2 100644 > > --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml > > @@ -17,13 +17,17 @@ properties: > > oneOf: > > - items: > > - enum: > > - - sprd,sc9632-uart > > No, not explained, not justified. > > > - sprd,sc9860-uart > > - sprd,sc9863a-uart > > - sprd,ums512-uart > > - sprd,ums9620-uart > > - const: sprd,sc9836-uart > > - const: sprd,sc9836-uart > > + - items: > > + - enum: > > + - sprd,sc9632-uart > > + - const: sprd,sc9632-uart > > This means nothing. Device cannot be compatible with itself. > Hi Krzysztof: We need UMS9632 SoC to compatible with sc9632. But now this patch version is submitted incorrectly, we will modify it in PATCH V2 version. Example: @@ -188,8 +188,8 @@ apb@20200000 { #size-cells = <1>; uart0: serial@0 { - compatible = "sprd,ums9620-uart", - "sprd,sc9836-uart"; + compatible = "sprd,ums9632-uart", + "sprd,sc9632-uart"; reg = <0 0x100>; interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>; clocks = <&ext_26m>; @@ -197,8 +197,8 @@ uart0: serial@0 { }; uart1: serial@10000 { - compatible = "sprd,ums9620-uart", - "sprd,sc9836-uart"; + compatible = "sprd,ums9632-uart", + "sprd,sc9632-uart"; reg = <0x10000 0x100>; interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>; clocks = <&ext_26m>; Thanks > > Best regards, > Krzysztof
