Dear Greg, > On Fri, Jan 17, 2025 at 06:18:22PM +0100, Andre Werner wrote: > > Fix the IRQ check to treat the negative values as No IRQ. > > > > Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx> > > --- > > V2: > > There are no changes to the patch itself. The previous patch submission > > had a very weird structure within the discussion thread: > > https://lkml.org/lkml/2025/1/16/398 > > This is simply a new thread opened for better handling. > > --- > > drivers/tty/serial/sc16is7xx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > > index 7b51cdc274fd..560f45ed19ae 100644 > > --- a/drivers/tty/serial/sc16is7xx.c > > +++ b/drivers/tty/serial/sc16is7xx.c > > @@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype, > > /* Always ask for fixed clock rate from a property. */ > > device_property_read_u32(dev, "clock-frequency", &uartclk); > > > > - s->polling = !!irq; > > + s->polling = (irq <= 0); > > if (s->polling) > > dev_dbg(dev, > > "No interrupt pin definition, falling back to polling mode\n"); > > -- > > 2.48.0 > > > > > > What commit id does this "fix"? 104c1b9dde9d859dd01bd2d71a2755a2fae43e15 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=104c1b9dde9d859dd01bd2d71a2755a2fae43e15 > > thanks, > > greg k-h > Regards, André
