On Thu, 16 Jan 2025 03:45:33 +0800 kernel test robot <lkp@xxxxxxxxx> wrote: > Hi Yenchia, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on tty/tty-testing] > [also build test WARNING on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.13-rc7 next-20250115] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yenchia-Chen/serial-8250_mtk-Add-ACPI-support/20250114-113715 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing > patch link: https://lore.kernel.org/r/20250114033324.3533292-1-yenchia.chen%40mediatek.com > patch subject: [PATCH] serial: 8250_mtk: Add ACPI support > config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20250116/202501160328.DUMWkTOc-lkp@xxxxxxxxx/config) > compiler: sh4-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250116/202501160328.DUMWkTOc-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202501160328.DUMWkTOc-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > >> drivers/tty/serial/8250/8250_mtk.c:662:36: warning: 'mtk8250_acpi_match' defined but not used [-Wunused-const-variable=] > 662 | static const struct acpi_device_id mtk8250_acpi_match[] = { > | ^~~~~~~~~~~~~~~~~~ > > > vim +/mtk8250_acpi_match +662 drivers/tty/serial/8250/8250_mtk.c > > 661 > > 662 static const struct acpi_device_id mtk8250_acpi_match[] = { > 663 { "MTKI0511", 0 }, > 664 {}, > 665 }; I'd drop the ACPI_PTR() use and just set it unconditionally. This table is tiny so not worth complexity of doing anything else. > 666 MODULE_DEVICE_TABLE(acpi, mtk8250_acpi_match); > 667 >