Re: [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is threaded weirdly.

On 16. 01. 25, 10:32, Andre Werner wrote:
Fix the IRQ check to treat the negative values as No IRQ.

Care to describe on what HW that can happen?

Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
---
  drivers/tty/serial/sc16is7xx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 7b51cdc274fd..560f45ed19ae 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1561,7 +1561,7 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
  	/* Always ask for fixed clock rate from a property. */
  	device_property_read_u32(dev, "clock-frequency", &uartclk);
- s->polling = !!irq;
+	s->polling = (irq <= 0);
  	if (s->polling)
  		dev_dbg(dev,
  			"No interrupt pin definition, falling back to polling mode\n");


--
js
suse labs




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux