On Fri, Dec 27, 2024 at 11:51:18PM +0106, John Ogness wrote: > Rather than using a hard-coded per-character Tx-timeout of 10ms, > use the frame rate to determine a timeout value. The value is > doubled to ensure that a timeout is only hit during unexpected > circumstances. > > Since the frame rate may not be available during early printing, > the previous 10ms value is kept as a fallback. ... > unsigned int status, tmout = 10000; > > - /* Wait up to 10ms for the character(s) to be sent. */ > + /* > + * Wait for a character to be sent. Fallback to a safe default > + * timeout value if @frame_time is not available. > + */ > + Redundant blank line (esp. after addressing below). > + if (up->port.frame_time) > + tmout = up->port.frame_time * 2 / NSEC_PER_USEC; This will be harder to maintain in case some new code will be squeezed in between, so I propose to make it if-else. -- With Best Regards, Andy Shevchenko
