Hi Claudiu, On Wed, Dec 4, 2024 at 4:58 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > Relocate the runtime PM enable operation to sci_probe_single(). This change > prepares the codebase for upcoming fixes. > > While at it, replace the existing logic with a direct call to > devm_pm_runtime_enable() and remove sci_cleanup_single(). The > devm_pm_runtime_enable() function automatically handles disabling runtime > PM during driver removal. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c > @@ -3440,7 +3434,6 @@ static int sci_probe_single(struct platform_device *dev, > > ret = uart_add_one_port(&sci_uart_driver, &sciport->port); > if (ret) { > - sci_cleanup_single(sciport); > return ret; > } Next line is: return 0; so please just merge that into return uart_add_one_port(&sci_uart_driver, &sciport->port); Actually [PATCH 5/6] makes that change, but there is no reason not to do that here. For the logical changes: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds