Hi, On Wed, Dec 11, 2024 at 7:40 AM Amal Raj T <tjarlama@xxxxxxxxx> wrote: > > From: Amal Raj T <amalrajt@xxxxxxxx> > > The current implementation of `poll_put_char` in the serial console driver > performs LF -> CRLF replacement, which can corrupt binary data. Since kdb > is the only user of `poll_put_char`, this patch moves the LF -> CRLF > replacement logic to kdb. > > Link: https://lore.kernel.org/linux-debuggers/Zy093jVKPs9gSVx2@telecaster/ > > Signed-off-by: Amal Raj T <amalrajt@xxxxxxxx> > --- > drivers/tty/serial/serial_core.c | 2 -- > kernel/debug/kdb/kdb_io.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) Looks reasonable. If someone comes out of the woodwork and says that this breaks them then we can try to figure out a solution as talked about previously [1]. It would be nice to include a link to the previous conversation in your comment message... With the reference to the previous conversation: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> [1] https://lore.kernel.org/r/20241115144933.GB4408@xxxxxxxxx
