On 03.12.2024 18:45, Claudiu Beznea wrote: > Hi, Geert, > > On 03.12.2024 18:30, Geert Uytterhoeven wrote: >> Using memcpy() prevents the compiler from doing any checking on the >> types of the passed pointer parameters. Copy the structure using struct >> assignment instead, to increase type-safety. >> >> No change in generated code on all relevant architectures >> (arm/arm64/riscv/sh). >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Not sure, do you think it should carry a fixes tag? > >> --- >> drivers/tty/serial/sh-sci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c >> index df523c7444230836..1ed13ce2c2952547 100644 >> --- a/drivers/tty/serial/sh-sci.c >> +++ b/drivers/tty/serial/sh-sci.c >> @@ -3542,7 +3542,7 @@ static int __init early_console_setup(struct earlycon_device *device, >> return -ENODEV; >> >> device->port.type = type; >> - memcpy(&sci_ports[0].port, &device->port, sizeof(struct uart_port)); >> + sci_ports[0].port = device->port; > > I'm currently preparing my fixes around this code. I think I should rebase s/I think/I'm not sure if/g > on top of your patch :) > > > Thank you, > Claudiu > >> port_cfg.type = type; >> sci_ports[0].cfg = &port_cfg; >> sci_ports[0].params = sci_probe_regmap(&port_cfg);
