Re: [PATCH 3/3] tty: serial: atmel: make it selectable for ARCH_LAN969X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 8, 2024 at 2:25 PM Nicolas Ferre
<nicolas.ferre@xxxxxxxxxxxxx> wrote:
>
> On 08/11/2024 at 12:22, Robert Marko wrote:
>
> A little commit message would be better.

Hi Nicolas, I basically reused the same commit description as for MFD
and else as all of the changes are
basically the same.


>
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > ---
> >   drivers/tty/serial/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 45f0f779fbf9..e6cf20b845f1 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -128,7 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
> >   config SERIAL_ATMEL
> >          bool "AT91 on-chip serial port support"
> >          depends on COMMON_CLK
> > -       depends on ARCH_AT91 || COMPILE_TEST
> > +       depends on ARCH_AT91 || ARCH_LAN969X ||COMPILE_TEST
>
> Checkpatch.pl reports some "DOS line endings", you might need to fix this.

Hm, I ran checkpatch before sending in verbose mode and I dont see
such a warning,
my Sublime text is also set to Unix endings, I also just checked with
cat -e and I dont see
any DOS endings.

Regards,
Robert
>
> >          select SERIAL_CORE
> >          select SERIAL_MCTRL_GPIO if GPIOLIB
> >          select MFD_AT91_USART
> > --
> > 2.47.0
>
>
> Once fixed, you can add my:
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>
> Thanks, best regards,
>    Nicolas



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@xxxxxxxxxx
Web: www.sartura.hr





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux