Also please fix the subject. See:
git log --oneline drivers/tty/hvc/hvc_opal.c
On 07. 11. 24, 8:10, Jiri Slaby wrote:
On 07. 11. 24, 6:47, liujing wrote:
The termno parameter is defined as an unsigned int
in hvc_opal_probe function,
"The termno parameter is defined as an unsigned int in hvc_opal_probe()."
We place () after function names, then "function" is not needed.
> So when it output should be modified to %u format.
I cannot parse this. Perhaps:
"So when it is output, a %u specifier should be used for formatting."
? But feel free to use your own words, but somehow spell (or chatgpt)
check it.
Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx>
diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index 095c33ad10f8..1d2e7f2ce088 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device
*dev)
/* Instanciate now to establish a mapping index==vtermno */
hvc_instantiate(termno, termno, ops);
} else {
- pr_err("hvc_opal: Device %pOF has duplicate terminal number
#%d\n",
+ pr_err("hvc_opal: Device %pOF has duplicate terminal number
#%u\n",
dev->dev.of_node, termno);
There are more occurrences of this. Care to fix them all?
thanks,
--
js
suse labs
