On Fri 2024-10-25 13:03:24, John Ogness wrote: > Currently serial8250_console_fifo_write() directly writes into the > UART_TX register, rather than using the high-level function > serial8250_console_putchar(). This is because > serial8250_console_putchar() waits for the holding register to > become empty. That would defeat the purpose of the FIFO code. > > Move the LSR_THRE waiting to a new function > serial8250_console_wait_putchar() so that the FIFO code can use > serial8250_console_putchar(). This will be particularly important > for a follow-up commit, where output bytes are inspected to track > newlines. > > This is only refactoring and has no functional change. > > Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx> Looks good: Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> Best Regards, Petr