On 29. 10. 24, 14:02, Tobias Klauser wrote:
In case of multiple Altera UART ports available on the system, the error
message will contain information about the port for which attaching the
IRQ handler failed.
And port->dev is properly set in altera_uart_probe().
Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
---
drivers/tty/serial/altera_uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/altera_uart.c b/drivers/tty/serial/altera_uart.c
index 8eed2542627e..1da9cd465426 100644
--- a/drivers/tty/serial/altera_uart.c
+++ b/drivers/tty/serial/altera_uart.c
@@ -307,7 +307,7 @@ static int altera_uart_startup(struct uart_port *port)
ret = request_irq(port->irq, altera_uart_interrupt, 0,
dev_name(port->dev), port);
if (ret) {
- pr_err(DRV_NAME ": unable to attach Altera UART %d "
+ dev_err(port->dev, "unable to attach Altera UART %d "
"interrupt vector=%d\n", port->line, port->irq);
The string should be on a single line. But that's a different story/patch.
thanks,
--
js
suse labs
