On Mon, Oct 14, 2024 at 09:04:15PM +0300, Omer Faruk BULUT wrote: > I check it with checkpatch. Then remove the NULL part. checkpatch may be false positive. Please, add a better analysis that it's fine to do a such cleanup. Note, this variable is _not_ static. ... > -const struct uart_ops *univ8250_port_base_ops = NULL; > +const struct uart_ops *univ8250_port_base_ops; Is it guaranteed to be NULL for non-static variables? If so, we want to know the details. > struct uart_ops univ8250_port_ops; -- With Best Regards, Andy Shevchenko
