On Thu, Oct 03, 2024 at 12:55:39PM -0700, Doug Anderson wrote: > On Tue, Oct 1, 2024 at 5:51 AM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > #define RX_DMA_PARITY_ERR BIT(5) > > #define RX_DMA_BREAK GENMASK(8, 7) > > #define RX_GENI_GP_IRQ GENMASK(10, 5) > > -#define RX_GENI_CANCEL_IRQ BIT(11) > > #define RX_GENI_GP_IRQ_EXT GENMASK(13, 12) > > +#define RX_GENI_CANCEL_IRQ BIT(14) > > This looks right, but do you want to fix all the rest of the wrong > bits in this list while you're at it? Things look OK up to the > "RX_FLUSH_DONE" and then they're wrong. Specifically: > > * My datasheet doesn't have RX_DMA_PARITY_ERR. Unless maybe it's one > of the "GP" IRQs? As you noticed, this one appears to be correct. > * My datassheet doesn't have RX_DMA_BREAK. Unless maybe it's one of > the "GP" IRQs (though why would it be two bits big?) And same here, apparently one is break on and the other break off. > * RX_GENI_GP_IRQ is 12:5, not 10:5 > > * My datasheet has RX_GENI_CMD_FAILURE as BIT(15). I'll just leave the rest as is for now. Johan
