Hi, On Tue, Oct 1, 2024 at 5:51 AM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > Serial drivers should not be dropping characters themselves, but at > least drop the unused 'drop' parameter from the receive handler for now. > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > drivers/tty/serial/qcom_geni_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Sure. I haven't spent any time figuring out what serial drivers are supposed to do with parity errors occur (I don't think I've ever used a UART that enabled the parity bit in all my years), but at least I agree that getting rid of this useless parameter makes sense. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> I guess while reviewing this patch I can also see that, indeed, parity errors seem to be "GP0" and break seems to be (strangely) GP2 and GP3. I guess that answers some of the questions I had on patch #5.
