On Wed, Oct 02, 2024 at 10:14:06AM -0400, Parker Newman wrote: > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > This series of patches replaces the custom 93cx6 EEPROM read functions in > the 8250_exar driver with the eeprom_93cx6 driver. This removes duplicate code > and improves code readability. > > In order to use the eeprom_93cx6 driver a quirk needed to be added to add an > extra clock cycle before reading from the EEPROM. This is similar to the > quirk in the eeprom_93xx46 driver. Everything is fine except one minor (in patch 1) and one more serious (see patches 3 & 4) issue. I just commented on them. Fix and send a final v4, my tags are already there and you may keep them. Thank you! -- With Best Regards, Andy Shevchenko