On Tue, Oct 1, 2024, at 11:21, Niklas Schnelle wrote: > On Thu, 2024-05-23 at 03:11 +0100, Maciej W. Rozycki wrote: > > With 2 more HAS_IOPORT patches having gone into v6.12-rc1 I'm looking > at what's left and we're down to 4 prerequisite patches[0] before being > able to compile-time disable inb()/outb()/…. This one being by far the > largest of these. Looking at your suggestion it seems that to compile > 8250_pci.c without HAS_IOPORT I'll have to add #ifdef CONFIG_HAS_IOPORT > around the MOXI section as that uses I/O ports unconditionally. The > rest seems fine and I guess would theoretically work on a system with > !HAS_IOPORT. I'll send a v2 with that included. I think that is the correct approach, yes. From what I can tell, the older version of the 8250 patch added the #ifdef blocks for all other port types that need port I/O, but the moxa version was added later than that and just needs the same change. Arnd