On Mon, 2024-04-08 at 12:17 +0200, Arnd Bergmann wrote: > On Mon, Apr 8, 2024, at 11:54, Ilpo Järvinen wrote: > > On Fri, 5 Apr 2024, Niklas Schnelle wrote: > > > > config SERIAL_8250_CS > > > tristate "8250/16550 PCMCIA device support" > > > - depends on PCMCIA && SERIAL_8250 > > > + depends on PCMCIA && SERIAL_8250 && HAS_IOPORT > > > help > > > Say Y here to enable support for 16-bit PCMCIA serial devices, > > > including serial port cards, modems, and the modem functions of > > > > What about drivers that use SERIAL8250_PORT()? > > It probably makes sense to hide these, since they won't ever > work. I probably missed them in my initial series because they > don't cause a compile-time error, but I agree that there is no > use in showing the options here. > As far as I can tell SERTIAL8250_PORT() is used by SERIAL_8250_ACCENT, SERIAL_8250_BOCA, and SERIAL_8250_EXAR_ST16C554 all of these already depend on ISA which implies HAS_IOPORT. So I don't think we need to add HAS_IOPORT dependencies here? Thanks, Niklas
