On Fri, 20 Sep 2024 17:55:33 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Fri, Sep 20, 2024 at 10:03:23AM -0400, Parker Newman wrote: > > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > > > Replace the custom 93cx6 EEPROM read functions with the eeprom_93cx6 > > driver. This removes duplicate code and improves code readability. > > > > exar_ee_read() calls are replaced with eeprom_93cx6_read() or > > eeprom_93cx6_multiread(). > > > > Add "select EEPROM_93CX6" to config SERIAL_8250_EXAR to ensure > > eeprom_93cx6 driver is also compiled when 8250_exar driver is selected. > > > > Note: Old exar_ee_read() and associated functions are removed in next > > patch in this series. > > Looks perfect! > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Let's wait for others and CIs to test all this and then after v6.12-rc1 > is out (presumably within ~ten days) rebase your series (as I suggested > in another reply) and send a v3. > Sounds good, I will wait for v6.12-rc1, rebase and send v3 with the changes you (or others) suggested. I promise I won't forget the Reviewed-by tags this time :). > Good work! > Thanks and thanks for the help! -Parker
