On Mon, Sep 16, 2024 at 12:55:05PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 14, 2024 at 08:58:50PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 13, 2024 at 10:55:40AM -0400, Parker Newman wrote:
>
> ...
>
> > > - printk(KERN_ERR "%s: timeout\n", __func__);
> > > + pr_err("%s: timeout\n", __func__);
> >
> > It's a device, please use dev_err().
>
> The problem is that this library doesn't know about this fact. I.e. it would
> need a new member just for this message. Instead, maybe drop the message as we
> anyway get a unique enough error code?
Fair enough, although adding real device pointers would be good to do in
the future...
thanks,
greg k-h
