On Fri, Sep 13, 2024 at 03:12:28PM -0400, Parker Newman wrote: > On Fri, 13 Sep 2024 20:54:05 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 13, 2024 at 10:55:40AM -0400, Parker Newman wrote: ... > > if you go with pr_fmt() perhaps it still makes sense to have separate changes. > > I dunno which one is better, up to you. > > Sorry if I am miss-reading but do you mean the pr_err() and pr_fmt() can be combined > and the read_poll_timeout() change should be made in a separate patch after? Possibly, I dunno. > Or should I be adding the pr_fmt() define in its own patch, followed by the pr_err() > and read_poll_timeout() in a patch? No, either altogether, or one patch for pr_err() + pr_fmt() and one for read_poll_timeout(). -- With Best Regards, Andy Shevchenko
