Re: [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Nick Chan <towinchenmi@xxxxxxxxx>
Subject: Re: [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9
From: Andi Shyti <andi.shyti@xxxxxxxxxx>
Date: Tue, 10 Sep 2024 14:41:27 +0200
Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, asahi@xxxxxxxxxxxxxxx
In-reply-to: <20240909084222.3209-4-towinchenmi@gmail.com>
References: <20240909084222.3209-1-towinchenmi@gmail.com> <20240909084222.3209-4-towinchenmi@gmail.com>

Hi Nick,

> +#define APPLE_S5L_UTRSTAT_RXTO_LEGACY	BIT(3)
>  #define APPLE_S5L_UTRSTAT_RXTHRESH	BIT(4)
>  #define APPLE_S5L_UTRSTAT_TXTHRESH	BIT(5)
>  #define APPLE_S5L_UTRSTAT_RXTO		BIT(9)
> -#define APPLE_S5L_UTRSTAT_ALL_FLAGS	(0x3f0)
> +#define APPLE_S5L_UTRSTAT_ALL_FLAGS	(0x3f8)

As you are here, you could use genmask

GENMASK(0xff, 3)

Andi

Follow-Ups:
- Re: [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9
  - From: Andi Shyti

References:
- [PATCH v4 0/3] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs
  - From: Nick Chan
- [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9
  - From: Nick Chan

Prev by Date: Re: [PATCH v4 0/3] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs
Next by Date: Re: [PATCH v4 1/3] tty: serial: samsung: Use BIT() macro for APPLE_S5L_*
Previous by thread: Re: [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9
Next by thread: Re: [PATCH v4 3/3] tty: serial: samsung: Fix serial rx on Apple A7-A9
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]